Improve restart of NetworkManager #20651
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This timeout aligns with the documented default value in https://open.qa/api/testapi/#_assert_script_run
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to solve https://progress.opensuse.org/issues/169531 - we don't really need full (the default if
EXPECTED_NM_CONNECTIVITYis not set) network connectivity in our test but also don't care if we have it so we need to expand the test to be able to check multiple values.The timeout was mainly added to avoid confusing additional output after the test already finished like e.g. visible in https://openqa.opensuse.org/tests/4625960#step/setup_multimachine/83